-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yoga layout support #67
Comments
I'm almost done with a version that works on Linux, I just need a few more days to work out the bugs. Once the proton-native side is ready, then there shouldn't be any more changes needed since everything else should be implemented in libui. For libui, the notable changes that I've made (on my fork) is add a fixed component using GtkFixed and add a way to get and set the size of any component. I need to find a way to implement that in Windows and Mac, but I assume they have easy support for fixed positioning and setting/getting the size. As for libui-node, I've added all of those bindings. Yoga isn't being built together with libui-node, but added with proton-native. I've had to change the compile options for libui-node because it and yoga were conflicting. The component is implemented as View and supports all of the options that View has on React Native. I need to see if I can implement setting the background color so that it's easier to see nested views. |
Can you details where they conflict? And which options you need to. Change? |
I couldn't find exactly what conflicted, but I found this in nbind's issues and it worked. kusti8/libui-node@57a957c |
I've added a PR to track my changes. All I need to do is add fixed positioning for Windows and Mac for libui and merge that. |
@kusti8 Is it still in development? I also have a question about running Yoga on JS side, it's interesting to see how it can impact perf 🤔 |
@roman01la This PR needs to be merged first: andlabs/libui#332. |
Proton Native V2 is now released! If the issue still occurs in the new update, please open a new issue. |
I'd like to add yoga layout, because Grid is pretty buggy and it would make it more similar to React Native. There are a few things that need to be done to make this work.
The text was updated successfully, but these errors were encountered: