Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProjectBuilder#build(String)は消す #86

Closed
YoshikiHigo opened this issue Jun 6, 2018 · 2 comments
Closed

ProjectBuilder#build(String)は消す #86

YoshikiHigo opened this issue Jun 6, 2018 · 2 comments

Comments

@YoshikiHigo
Copy link
Member

- projectBuilder.build(outDirPath);
+ projectBuilder.build(targetProject.getInitialVariant());
@shinsuke-mat
Copy link
Member

shinsuke-mat commented Jun 6, 2018

上記の修正例,シグネチャ的に正しいのはこうですが,

- projectBuilder.build(outDirPath);
+ projectBuilder.build(targetProject.getInitialVariant().getGeneratedSourceCode(), outDirPath);

そもそもNullPointerException出る.
つまり,ProjectBuilder#build(GeneratedSourceCode, String)が正しく動いていない.
併せて修正してもらえると助かります.

諸悪の根源はここっぽい.

// GeneratedJDTAST.java L31
@Override
public String getPrimaryClassName() {
  // TODO Auto-generated method stub
  return null;
}

@YoshikiHigo
Copy link
Member Author

すみません,そのメソッドはテストしていませんでした…
GeneratedJDTAST#getPrimaryClassNameは誰の管轄でしたっけ?ASTの操作だからr-arimaくん?
getPrimacyClassNameの実装が完了したら,buildメソッドの修正を行います.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants