Something weird happens with boolean functions applied to over

[kutyel]

https://codesandbox.io/s/opticsjs-example-ov3ll?file=/src/index.js

[serras]

I am pretty sure it's something related to this line, which reads:

obj => (isNotFound(obj) ? notFound : obj[key] || notFound),

That obj[key] || notFound is there to cover the case in which key is not a property of obj, but it will also catch the case in which obj[key] is false, returning notFound then.

[kutyel]

this simple test does not pass:

  test('over should work with boolean functions', () => {
    const neg = x => !x
    const liked = { liked: true }
    const lens = optic('liked')

    expect(view(lens, liked)).toBe(true)
    expect(view(lens, over(lens, neg, liked))).toBe(false)
  })

[github-actions]

🎉 This issue has been resolved in version 2.2.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀