Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when using noImplicitAny in a typescript project #136

Closed
brako opened this issue Oct 17, 2023 · 6 comments
Closed

Error when using noImplicitAny in a typescript project #136

brako opened this issue Oct 17, 2023 · 6 comments

Comments

@brako
Copy link

brako commented Oct 17, 2023

Hello,

I have multiple noImplicitAny errors when building my project, despites having the following config:

{
    "skipLibCheck": true,
    "noImplicitAny": true
}

It is probably related to the issue: microsoft/TypeScript#15363

It looks like .ts file should not be shipped in the release.

Thanks

@ajfranzoia
Copy link

I'm having the same issue

@brako
Copy link
Author

brako commented Nov 7, 2023

Looks like the .npmignore is configured to ignore .ts files but it is not working.
*.ts !*.d.ts

Maybe the build output and sources should be in separate folders to prevent mixing them when publishing the module.

@indigolain
Copy link

It looks like the change to filter out the ts files in .npmignore was introduced on Oct 14, 2023.
3d37ad8

While the newest version of hls-parser was released Oct 9, 2023 according to npm, prior to the changes mentioned above.
https://www.npmjs.com/package/hls-parser?activeTab=versions

Maybe if we publish a new version, the problem will go away? @kuu is there any chance of deploying a new version?

@kuu
Copy link
Owner

kuu commented Mar 17, 2024

I just published the main to npm

@indigolain
Copy link

@kuu
Thank you for responding so quickly!
Looks like .ts files are gone from the release as expected! ✨ I think we can close this issue 🚀

@kuu
Copy link
Owner

kuu commented Mar 17, 2024

@indigolain Thanks for confirming that! Will close.

@kuu kuu closed this as completed Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants