Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Until option for recurrence #10

Merged
merged 1 commit into from
Jun 14, 2020

Conversation

DirkReiners
Copy link

A fairly simple change, just adding the until parameter to recurrence options.

@kuzmoyev kuzmoyev changed the base branch from master to dev June 11, 2020 08:21
@kuzmoyev kuzmoyev linked an issue Jun 11, 2020 that may be closed by this pull request
Copy link
Owner

@kuzmoyev kuzmoyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your pull request. I believe it is your first contribution to the open-source project. It is the first contribution to my open-source project from another developer. So thank you for that. That's a beer worthy occasion! :)

I've added a small comment for a typo in the error message. If you push a fix into your fork, it should appear in this pull request. And I'll merge it afterward.

gcsa/recurrence.py Show resolved Hide resolved
@kuzmoyev kuzmoyev merged commit 47ffab6 into kuzmoyev:dev Jun 14, 2020
kuzmoyev added a commit that referenced this pull request May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recurrence missing 'until' option
3 participants