Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unique_ptr to manage LogicalType #1853

Closed
andyfengHKU opened this issue Jul 24, 2023 · 0 comments
Closed

Use unique_ptr to manage LogicalType #1853

andyfengHKU opened this issue Jul 24, 2023 · 0 comments

Comments

@andyfengHKU
Copy link
Contributor

Our LogicalType used to a enum so it is not managed by smart pointer. Now since it can be recursive, we should change it to be managed by unique_ptr. Also, when it being passed as a parameter, const reference is preferred.
@ray6080 ray6080 closed this as completed Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ray6080 @andyfengHKU