Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate constants from types in types.h #93

Closed
ray6080 opened this issue Apr 4, 2021 · 0 comments
Closed

Separate constants from types in types.h #93

ray6080 opened this issue Apr 4, 2021 · 0 comments
Labels
feature New features or missing components of existing features

Comments

@ray6080
Copy link
Contributor

ray6080 commented Apr 4, 2021

Currently, in types.h, we have system-level types such as gf_string_t, nodeID_t, etc. And we also have constants such as MAX_VECTOR_SIZE, NUM_BYTES_PER_NODE_ID, etc.
It's more clear to separate constants from types into a separate constants.h file when we have more system-level constants avaiable.
@queryproc queryproc added the feature New features or missing components of existing features label Apr 18, 2021
@ray6080 ray6080 closed this as completed Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New features or missing components of existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ray6080 @queryproc