fix: catch errors when updating the mappings on startup #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afondard
approved these changes
Apr 8, 2024
fmauNeko
approved these changes
Apr 8, 2024
Kuruyia
added a commit
that referenced
this pull request
Apr 9, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
# [2.4.0-beta.16](v2.4.0-beta.15...v2.4.0-beta.16) (2024-04-09) ### Bug Fixes * catch errors when updating the mappings on startup ([#338](#338)) ([e09c5a3](e09c5a3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Currently, KDM crashes the Kuzzle instance on startup when it fails to update the mapping of an engine collection to match the models that are stored in the database, making it impossible for someone to fix the models without connecting directly to the Elasticsearch database.
This fixes this crash by adding a try-catch block when the engines are updated on startup to notify the user that a problem occurred instead. Various try-catch blocks were also added on the collection creation methods to provide more context on where the error occurred.
This is associated with JIRA ticket KZLPRD-220.