Kzlprd 166 upsert assets #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmauNeko
requested changes
Dec 29, 2023
Juiced66
reviewed
Dec 29, 2023
Juiced66
reviewed
Dec 29, 2023
Juiced66
reviewed
Dec 29, 2023
rolljee
requested changes
Jan 8, 2024
| upsert: { | ||
| handler: this.upsert.bind(this), | ||
| http: [ | ||
| { path: "device-manager/:engineId/assets/:_id", verb: "post" }, |
There was a problem hiding this comment.
This path does not reflect the behaviour of this action
There was a problem hiding this comment.
I used POST by following this : https://docs.kuzzle.io/core/2/api/controllers/document/upsert/
Should I change it to PUT?
There was a problem hiding this comment.
Nah, you are right I though the path was the same as the update action, but nvm it's okay :)
rolljee
approved these changes
Jan 8, 2024
fmauNeko
approved these changes
Jan 9, 2024
sebtiz13
pushed a commit
that referenced
this pull request
Jan 9, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
# [2.4.0-temp-ci-debug.1](v2.3.2...v2.4.0-temp-ci-debug.1) (2024-01-11) ### Bug Fixes * **asset_migration:** fixes multiple assets migration and optimize ([fd546cf](fd546cf)) * **assetsGroups:** disable checkRights on impersonate ([#325](#325)) ([eaa3edc](eaa3edc)) * **assets:** migrate tenant only if user is admin ([c24f942](c24f942)) * **assetsMigrateTenant:** add type for frontend and fix admin only ([e249f13](e249f13)) * **ci:** correct github token in ci ([a5a6b69](a5a6b69)) * copy-version script ([72b5e49](72b5e49)) * correct KuzzleRequest for pipes ([ef932d1](ef932d1)) * **export:** correct scroll in getNamedMeasures ([05fe4fd](05fe4fd)) * improve get internal devices documents ([03ccb29](03ccb29)) * **migrateTenant:** clear groups of newly created assets ([79f6a5a](79f6a5a)) * **npm:** fix repository url ([514dc59](514dc59)) * update semantic-release ([380c8b3](380c8b3)) ### Features * **asset:** add upsert method ([#323](#323)) ([5f87787](5f87787)) * **assets:** assets migrate tenant ([5f05101](5f05101)) * digitaltwin exports ([#315](#315)) ([aab65af](aab65af)) * **digitalTwin:** allow to modify mapping from application ([#322](#322)) ([89d375a](89d375a)) * **digitalTwin:** implement generic document pipes triggers ([#321](#321)) ([60a21fc](60a21fc)) * improve export ([#316](#316)) ([51db84a](51db84a)) * **measures:** add lastMeasuredAt on DigitalTwin ([#314](#314)) ([05b8a53](05b8a53))
github-actions bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
# [2.4.0-temp-ci-debug.1](v2.3.2...v2.4.0-temp-ci-debug.1) (2024-01-11) ### Bug Fixes * **asset_migration:** fixes multiple assets migration and optimize ([fd546cf](fd546cf)) * **assetsGroups:** disable checkRights on impersonate ([#325](#325)) ([eaa3edc](eaa3edc)) * **assets:** migrate tenant only if user is admin ([c24f942](c24f942)) * **assetsMigrateTenant:** add type for frontend and fix admin only ([e249f13](e249f13)) * **ci:** correct github token in ci ([a5a6b69](a5a6b69)) * copy-version script ([72b5e49](72b5e49)) * correct KuzzleRequest for pipes ([ef932d1](ef932d1)) * **export:** correct scroll in getNamedMeasures ([05fe4fd](05fe4fd)) * improve get internal devices documents ([03ccb29](03ccb29)) * **migrateTenant:** clear groups of newly created assets ([79f6a5a](79f6a5a)) * **npm:** fix repository url ([514dc59](514dc59)) * update semantic-release ([380c8b3](380c8b3)) ### Features * **asset:** add upsert method ([#323](#323)) ([5f87787](5f87787)) * **assets:** assets migrate tenant ([5f05101](5f05101)) * digitaltwin exports ([#315](#315)) ([aab65af](aab65af)) * **digitalTwin:** allow to modify mapping from application ([#322](#322)) ([89d375a](89d375a)) * **digitalTwin:** implement generic document pipes triggers ([#321](#321)) ([60a21fc](60a21fc)) * improve export ([#316](#316)) ([51db84a](51db84a)) * **measures:** add lastMeasuredAt on DigitalTwin ([#314](#314)) ([05b8a53](05b8a53))
github-actions bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
# [2.4.0-temp-ci-debug.1](v2.3.2...v2.4.0-temp-ci-debug.1) (2024-01-11) ### Bug Fixes * **asset_migration:** fixes multiple assets migration and optimize ([fd546cf](fd546cf)) * **assetsGroups:** disable checkRights on impersonate ([#325](#325)) ([eaa3edc](eaa3edc)) * **assets:** migrate tenant only if user is admin ([c24f942](c24f942)) * **assetsMigrateTenant:** add type for frontend and fix admin only ([e249f13](e249f13)) * **ci:** correct github token in ci ([a5a6b69](a5a6b69)) * copy-version script ([72b5e49](72b5e49)) * correct KuzzleRequest for pipes ([ef932d1](ef932d1)) * **export:** correct scroll in getNamedMeasures ([05fe4fd](05fe4fd)) * improve get internal devices documents ([03ccb29](03ccb29)) * **migrateTenant:** clear groups of newly created assets ([79f6a5a](79f6a5a)) * **npm:** fix repository url ([514dc59](514dc59)) * update semantic-release ([380c8b3](380c8b3)) ### Features * **asset:** add upsert method ([#323](#323)) ([5f87787](5f87787)) * **assets:** assets migrate tenant ([5f05101](5f05101)) * digitaltwin exports ([#315](#315)) ([aab65af](aab65af)) * **digitalTwin:** allow to modify mapping from application ([#322](#322)) ([89d375a](89d375a)) * **digitalTwin:** implement generic document pipes triggers ([#321](#321)) ([60a21fc](60a21fc)) * improve export ([#316](#316)) ([51db84a](51db84a)) * **measures:** add lastMeasuredAt on DigitalTwin ([#314](#314)) ([05b8a53](05b8a53))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR adds an upsert method in the AssetService. The upsert method is designed to update an existing asset with new metadata, or create a new asset if one does not already exist with the specified assetId.
How should this be manually tested?
npm run test:functional
Other changes
Boyscout