Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topologically sort nodes from gltf import #10

Closed
kvark opened this issue Jan 9, 2022 · 0 comments · Fixed by #11
Closed

Topologically sort nodes from gltf import #10

kvark opened this issue Jan 9, 2022 · 0 comments · Fixed by #11
Labels
bug Something isn't working

Comments

@kvark
Copy link
Owner

kvark commented Jan 9, 2022

It looks like gltf likes to specify node parents after children:

Node Some("Point_Orientation")
Node Some("Point")
        -> Some("Point_Orientation")
Node Some("Camera_Orientation")
Camera Some("Camera") depth 0.1..1000.0 proj Perspective { fov_y: 22.895193 } at Node { parent: NodeRef(1), local: Space { position: Vec3(0.0, 0.0, 0.0), scale: 1.0, orientation: Quat(-0.70710677, 0.0, 0.0, 0.70710677) } }
Node Some("Camera")
        -> Some("Camera_Orientation")

We need to handle this better. Currently the parent nodes are missed completely.

@kvark kvark added the bug Something isn't working label Jan 9, 2022
@kvark kvark closed this as completed in #11 Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant