Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No PhoneNumberField in 0.10.0 release #39

Closed
brandones opened this issue Jan 28, 2016 · 6 comments
Closed

No PhoneNumberField in 0.10.0 release #39

brandones opened this issue Jan 28, 2016 · 6 comments

Comments

@brandones
Copy link

  File "/Users/bistenes/Code/webthing/src/application/forms.py", line 16, in <module>
    from wtforms_components import PhoneNumberField
ImportError: cannot import name PhoneNumberField

Works fine up until 0.9.9.

@hyperknot
Copy link

This one is very serious, as wtforms_alchemy depends on wtforms-components, and now every wtforms_alchemy install is broken, unless manually pinning down the components dependency!

@kvesteri
Copy link
Owner

Released new version of WTForms-Alchemy. Now WTForms-Alchemy contains all SQLAlchemy-dependent fields (for example PhoneNumberField).

@hyperknot
Copy link

@kvesteri I'd kindly ask you to please synchronise such releases in the future by changing the dependencies before and after release. If anyone has every deployed a server with a pip install yesterday it ended up in a broken state.

What could have been a solution is to:

  • change alchemy to components<0.10, release an old alchemy with updated dependency
  • release components 0.10
  • release new alchemy with components >= 0.10

@brandones
Copy link
Author

It would also be cool to give clients of your code a little warning in the future.
https://wiki.python.org/moin/PythonDecoratorLibrary#Generating_Deprecation_Warnings

@kvesteri
Copy link
Owner

Duly noted and I'm sorry for all the hassle this caused.

@dappiu
Copy link

dappiu commented Oct 6, 2016

PhoneNumberType is still present in WTForms-Components documentation, but missing in the code. For what I understand, PhoneNumberType was moved permanently on WTForms-Alchemy package, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants