Skip to content

Commit 87aa264

Browse files
committed
KVM: selftests: Randomly force emulation on x86 writes from guest code
Override vcpu_arch_put_guest() to randomly force emulation on supported accesses. Force emulation of LOCK CMPXCHG as well as a regular MOV to stress KVM's emulation of atomic accesses, which has a unique path in KVM's emulator. Arbitrarily give all the decisions 50/50 odds; absent much, much more sophisticated infrastructure for generating random numbers, it's highly unlikely that doing more than a coin flip with affect selftests' ability to find KVM bugs. This is effectively a regression test for commit 910c57d ("KVM: x86: Mark target gfn of emulated atomic instruction as dirty"). Link: https://lore.kernel.org/r/20240314185459.2439072-6-seanjc@google.com Signed-off-by: Sean Christopherson <seanjc@google.com>
1 parent 2f2bc6a commit 87aa264

File tree

1 file changed

+21
-0
lines changed

1 file changed

+21
-0
lines changed

tools/testing/selftests/kvm/include/x86_64/kvm_util_arch.h

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
#include <stdbool.h>
66
#include <stdint.h>
77

8+
#include "test_util.h"
9+
810
extern bool is_forced_emulation_enabled;
911

1012
struct kvm_vm_arch {
@@ -22,4 +24,23 @@ static inline bool __vm_arch_has_protected_memory(struct kvm_vm_arch *arch)
2224
#define vm_arch_has_protected_memory(vm) \
2325
__vm_arch_has_protected_memory(&(vm)->arch)
2426

27+
#define vcpu_arch_put_guest(mem, __val) \
28+
do { \
29+
const typeof(mem) val = (__val); \
30+
\
31+
if (!is_forced_emulation_enabled || guest_random_bool(&guest_rng)) { \
32+
(mem) = val; \
33+
} else if (guest_random_bool(&guest_rng)) { \
34+
__asm__ __volatile__(KVM_FEP "mov %1, %0" \
35+
: "+m" (mem) \
36+
: "r" (val) : "memory"); \
37+
} else { \
38+
uint64_t __old = READ_ONCE(mem); \
39+
\
40+
__asm__ __volatile__(KVM_FEP LOCK_PREFIX "cmpxchg %[new], %[ptr]" \
41+
: [ptr] "+m" (mem), [old] "+a" (__old) \
42+
: [new]"r" (val) : "memory", "cc"); \
43+
} \
44+
} while (0)
45+
2546
#endif // SELFTEST_KVM_UTIL_ARCH_H

0 commit comments

Comments
 (0)