Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to use interface between user-specified classes as shoreline #435

Open
sebbelese opened this issue Jul 27, 2023 · 4 comments
Open
Labels
enhancement New feature or request

Comments

@sebbelese
Copy link

sebbelese commented Jul 27, 2023

The shorelines are currently only determined from the MNDW, and that the pixel classification is used to determine the threshold. The MNDW may not be relevant in all cases. Further, we may want to consider the vegetation/beach interface as shoreline to avoid the noise related to tides. This interface cannot be accurately captured using the MNDW.

I added a setting option to not use the MNDWI to extract shorelines but instead use the interface between user-specified classes as shoreline:

Interface sand / whitewater+water
image

Interface sand/other
image

Let me know if you are interested in a merge request

@sebbelese sebbelese changed the title How is surface classification related to shoreline detection? Possibility to use interface between user-specified classes as shoreline Aug 10, 2023
@kvos
Copy link
Owner

kvos commented Sep 15, 2023

yes you can add in pull request, pls make sure it is in a separate function that can be called instead of extract_shorelines() and then document it. It's best if you merge your changes with the development branch. thanks a lot for your contribution

@kvos kvos added the enhancement New feature or request label Dec 18, 2023
@xiyang712
Copy link

@sebbelese It's really cool. I'm interested in this. Can you tell me how this is achieved and can you share files?

@sebbelese
Copy link
Author

sebbelese commented Mar 26, 2024

@sebbelese It's really cool. I'm interested in this. Can you tell me how this is achieved and can you share files?
Hello,

I did not initiate the pull request initially because I did not implement it following kvos' requirements, and I was not working on this project anymore at that time.

Edit : Unfortunately, I do not have access to the code anymore, it was from my previous job.

The technique was quite simple: filling with zeros all the classes that should be on one side, filling with ones all the classes on the other side, the define the boundary between zeros and ones.

@kvos
Copy link
Owner

kvos commented May 23, 2024

@sebbelese and @xiyang712 , want to point out that a new toolbox has been released to specifically map vegetation lines, check it out https://github.com/fmemuir/COASTGUARD/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants