Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag Release #44

Closed
tooolbox opened this issue Jun 28, 2020 · 2 comments
Closed

Tag Release #44

tooolbox opened this issue Jun 28, 2020 · 2 comments

Comments

@tooolbox
Copy link

tooolbox commented Jun 28, 2020

Hello maintainers!

(I saw this so that may be @abronan or @Victorcoder or @nmengin or @mthenw )

I just ran into duplicate protobuf registration for etcd which seems to be fixed with 5ce5a68 / #40

Amusingly, using that commit in my go.mod does affect the panic I'm running into, but just changes it to:

go/pkg/mod/go.etcd.io/etcd@v0.5.0-alpha.5.0.20200329194405-dd816f0735f8/auth/authpb/auth.pb.go:115 +0x10a

sigh

Regardless, I thought it might be a good idea to tag that commit as v0.1.1 so people pulling in this project newly get that fix, otherwise Go Modules will default to v0.1.0 and then they'll encounter the bug and have to have the determination to figure it out and eventually wind up here :)

Thanks!

EDIT: As a further note, I did just get it to work by ensuring that my project matched the version of etcd that Valkeyrie was importing. I was using v3.3.0-rc.0.0.20200626182840-e94dc39edcf9 versus v0.5.0-alpha.5.0.20200329194405-dd816f0735f8. I'll admit that I floundered around for a while trying to determine what the correct version was to import for Go Modules--seems like that project is a bit of a disaster from that perspective.

@vcastellm
Copy link

Thanks @tooolbox, @abronan I think it's a good idea to add a new tag, WDYT?

@abronan
Copy link
Member

abronan commented Jul 8, 2021

I just tagged a v0.2.0 including #49 which should fix all of this mess with the new client structure.

@ldez ldez closed this as completed Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants