-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document::get_root_element #29
Comments
I wanted to mirror the simplicity of the However, I am now seeing the Perl API is in fact more honest and returns an undef when there is no element: So I agree with you that a refactor is needed here. I don't mind changing the return type at all, as long as we honestly reflect that in the release numbers, which we will. |
I take it you were suggesting an |
Yes, if there wasn't something that I hadn't thought about. Good |
Closing here, looking forward to the refactor branch 👍 Quite excited to "enlighten" the wrapper with your RefCell approach |
So I've started working on pointer book keeping. The method below returns a Node with the doc_ptr as node_ptr if there is no root element. Is there a reason for this? I think this will add complexity as I would have to add it to a list of known nodes and do a lot of checks if the node is infact a node or a document. Would this be something we can change? I know we would like to keep api compatbility.
rust-libxml/src/tree.rs
Line 100 in 75f0655
The text was updated successfully, but these errors were encountered: