Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract keySpecificKeyup code into internal plugin #143

Closed
marad opened this issue May 21, 2020 · 0 comments
Closed

Extract keySpecificKeyup code into internal plugin #143

marad opened this issue May 21, 2020 · 0 comments
Assignees
@marad
Labels
architecture cleancode

Comments

@marad
Copy link
Member

marad commented May 21, 2020 •
edited

Currently the code for keySpecificKeyup is kind of out of place. It serves a useful purpose, but I don't think it should belong to the core. I think this should be an internal plugin.

This evolved from #129.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marad marad

Labels
architecture cleancode
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sanity @marad