Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add movie modal popup #25

Merged
merged 4 commits into from Jun 22, 2022
Merged

Add movie modal popup #25

merged 4 commits into from Jun 22, 2022

Conversation

kwekubright
Copy link
Owner

Description:

In this feature I did the following:

  • Created a comments popup only with the top section (displaying details of the selected item) ✅
  • When the popup loads, the webapp retrieves data from the selected API and shows details about the selected item. ✅
  • Added event to comment button to open your popup. ✅

image

Copy link
Collaborator

@abdulhamiid abdulhamiid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Changes Required ♻️

  • No linters error ✔
  • All test passed ✔
  • Nice Implementation of feature ✔

Suggested changes

  • If you can increase the popup width to remove the scrolling effect

@kwekubright
Copy link
Owner Author

Hi @abdulhamiid, Thanks for your review.
There is actually no scrolling effect on my end when I preview the changes. Can you please share an image showing the scrolling effect at your end so I can better understand the issue and correct it?

@abdulhamiid
Copy link
Collaborator

js-project

@kwekubright kwekubright merged commit 16234c0 into development Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants