Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to multiple set-cookie headers #3

Open
wants to merge 2 commits into
base: v0.x
Choose a base branch
from

Conversation

oseau
Copy link

@oseau oseau commented Nov 8, 2022

Hi,

Currently multiple set-cookie headers is folded into one header, eg:

'set-cookie': 'a=aValue; Max-Age=86400; Path=/w; HttpOnly; Secure; SameSite=None, b=bValue; Max-Age=86400; Path=/w; HttpOnly; Secure; SameSite=None',

However the correct header should be:

'set-cookie': [
    'a=aValue; Max-Age=86400; Path=/w; HttpOnly; Secure; SameSite=None',
    'b=bValue; Max-Age=86400; Path=/w; HttpOnly; Secure; SameSite=None'
  ],

I made a quick fix according to the info here https://developers.cloudflare.com/workers/runtime-apis/headers/#differences

Thanks for this awesome lib.

@oseau
Copy link
Author

oseau commented Nov 16, 2022

any updates? @kwhitley

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant