Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support missing response #5

Closed
danew opened this issue Nov 22, 2022 · 1 comment
Closed

Support missing response #5

danew opened this issue Nov 22, 2022 · 1 comment

Comments

@danew
Copy link
Contributor

danew commented Nov 22, 2022

The corsify function throws a TypeError if the function is called without a response.

Instead, I believe the handler should check if the response exists first and if not throw an appropriate error.

Cloudflare workers throws:

[mf:err] POST /nada: FetchError [ERR_NO_RESPONSE]: No fetch handler responded and no upstream to proxy to specified.
Make sure you're returning a `Response` in your handler.
@danew danew mentioned this issue Nov 22, 2022
Merged
@kwhitley
Copy link
Owner

kwhitley commented Feb 8, 2023

Addressed in #6

@kwhitley kwhitley closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kwhitley @danew