New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass FormData in as-is #11
Conversation
i did this! |
@danawoodman you need to stub in FormData or run it in an environment like MiniFlare or CF Workerd where FormData is stubbed in for you. |
@Crisfole Why would it not need to be stubbed locally tho? I'm running the same build/test commands |
This also brings up a question: if FormData isn't available, itty-fetcher will fail; what can we do about that? |
I assume fetch would fail if those aren't available anyways, without some kind of poly fill/override. Now how do we fix these tests since they work fine locally? |
@danawoodman what's your local env like? (Node version?) |
I must be using 18. Will confirm when I'm home |
This is awesome, only comment is that thing about 18.0.0 vs 18.10.0, but i'll merge and tweak that :) |
@kwhitley thanks! I didn't see a note on 18, what was your question? 18.10.0 is the latest version so I opted for that for local dev. The actual action runs on anything 18+ which I think is ok |
FormData
as-is instead ofJSON.stringify
ing it as we do now. Should only add a few bytes to the final bundleFormData
Closes #10