Add safe checking of payload data type to prevent undefined errors #23
Conversation
Solid!! |
|
This a WIP still? See it's back in draft mode... |
|
Either way, killer job you two! |
|
@kwhitley sorry yeah I think it's ready for review. Def need to improve the type checking to be more robust tho |
danawoodman
changed the title
| const is_blob = typeof Blob !== 'undefined' && payload instanceof Blob | ||
| const is_arraybuffer = typeof Uint8Array !== 'undefined' && payload instanceof Uint8Array | ||
| const passthrough = is_formdata || is_blob || is_arraybuffer | ||
|
|
There was a problem hiding this comment.
Granted this should minify somewhat...
There was a problem hiding this comment.
I think you can make this smaller by keying on 'raw' post content vs stringify post content:
fetcher.post('/whatever', raw(myBlobHere))A tiny function raw could simply tag the object with a symbol to skip the stringification...
There was a problem hiding this comment.
I think I figured out a better approach! Using Object.getPrototypeOf() we can sniff the type of the object. If it is of type Object we can stringify it otherwise we pass through. Think this could work? Feels more robust than what were doing now
|
Ok, live in |
This fixed issues where Blob/FormData are being reported as undefined. It also makes our auto content-type/
JSON.stringifycode work more reliably.Also added checking for
Uint8Array. May eventually need to support more content types.Thanks to @Crisfole for the tip on using
typeof FormData !== "undefined"!Closes #16
Closes #21