Pass payload data to query params for GET requests #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crisfole
reviewed
Sep 29, 2022
| method, | ||
| } = options | ||
| const method = options.method.toUpperCase() | ||
| const resolvedURL = new URL(options.base + url) |
There was a problem hiding this comment.
I think the + is likely to be contentious or need documentation...
There was a problem hiding this comment.
That was already existing. I would prefer to do a more intelligent concatenation tho
There was a problem hiding this comment.
This is a reference to #2 not your fault.
Once it's merged, and we have test coverage, we can play further for byte-shaving :) |
|
@kwhitley I added tests for the changes, did you see something missing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests. Note that I had to move the tests into a
beforeEachso I can assert against thecallsotherwise I get all them mock calls in the test.Adds about 110 bytes, not sure if it is possible to reduce further.