-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gas and fees #410
Comments
Missed this, will circle back after release with some thoughts |
I've been thinking a lot about gas and fees. Monetization is a big focus for us this year, and so in addition to block gas limits, it is becoming a big priority. The intent of the transaction No real suggestions here, but we don't have any strict precedents / legacy to adhere to, so we can design a solution as we wish. |
I think is bumped fro 0.8, but perhaps tentatively could find it's way to 0.8 with some initial iteration? I'll put in in the 0.8.0 milestone so we can make the plan definitive and remove it or not. |
There are a few things to decide upon regarding gas and fees in Kwil.
First, there's a funny detail regarding the txn fee in all of our spending code where if a transaction specifies a fee
X
>price
, the actual amount spent from the account's balance is justprice
rather thanX
. That essentially makes theFee
field of the transaction body more like the fee limit, but it is not documented this way. I feel like the transaction should reduce account balance by the given fee. Or is there a reason to interpret this as a limit, like removing a painful client footgun?Another thing is gas vs. fee. We have an implicit gas cost of unity i.e. 1 atom (a kwil?) per gas. The transaction has no way to specify a fee rate, which is typically how transactions would be prioritized on a busy chain, just an absolute fee or fee limit depending on how we want to interpret this field.
Lastly, every abci module returns an "ExecutionResponse" with
GasUsed
left at zero, only aFee
set. The event logs are confusing since they say gasUsed is zero despite a fee being paid based on our hardcoded "prices". This is sorta OK since we are handling execution costs (gas!) at the app level, and keeping cometBFT blind to it. So, do we remove this "gas used" info and keep cometbft in the dark, or do we formalize what we mean by gas and fees?I think it's too late for big decisions for 0.6.0, but we should discuss these points anyway.
The text was updated successfully, but these errors were encountered: