Pagination Support #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses an issue where sometimes Rackspace sends down the error dict directrly, rather than with "message" and "detail" nested within another key. This will make the error be processed correctly in either case. It also adds the details to the error string on the output, when available.
This commit adds support for listing records beyond the first 100, by detecting and following Rackspace pagination markers.
|
This worked for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rackspace paginates any list-esque calls to their API. Therefore, such calls from
rackdnswill return only the first 100 results. If you have more than 100 records (say, because you have lots of subdomains on a given domain), it is impossible to see the ones beyond the first 100 with this tool.This pull request adds support for pagination, automatically detecting if a
totalEntrieskey is sent down that is greater than 100 and making additional requests using theoffsetGET key until all records have been retrieved.It also fixes a slight bug with error handling.