Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UE5.1 Support? #16

Open
benjs2000 opened this issue Dec 19, 2022 · 24 comments
Open

UE5.1 Support? #16

benjs2000 opened this issue Dec 19, 2022 · 24 comments

Comments

@benjs2000
Copy link

Love this plugin, though struggling to get it working with UE5.1 (have tried auto build when launching project but failed)
Any advice on how I can build this myself to work with 5.1?
Cheers

@kabassmusic
Copy link

I created a fork that updates it to work with 4.26.
I think it works with 5.0 as well. I'll do some testing today and let you know. This github has been dead for awhile.

@kabassmusic
Copy link

kabassmusic commented Dec 19, 2022

@benjs2000 Okay. I have tested the 4.26 version with 5.1 and it rebuilt and packaged fine. Try out my fork and let me know.

https://github.com/kabassmusic/WAC-4.26

@benjs2000
Copy link
Author

@kabassmusic Thanks. I've built it and while I can load the plugin, I'm getting this UE crash when I hit play. Any ideas?

Fatal error: [File:D:\build++UE5\Sync\Engine\Source\Runtime\Core\Private\Containers\Array.cpp] [Line: 8] Trying to resize TArray to an invalid size of 4294967295

UnrealEditor_Core
UnrealEditor_WindowsAudioCapture!FAudioCaptureWorker::GetFrequencyArray() [C:\Users*\Syncalo\UnrealProjects\MyProjectTest\Plugins\WindowsAudioCapture\Source\WindowsAudioCapture\Private\AudioCaptureWorker.cpp:108]
UnrealEditor_WindowsAudioCapture!UWindowsAudioCaptureComponent::execBP_GetFrequencyArray() [C:\Users*
\Syncalo\UnrealProjects\MyProjectTest\Plugins\WindowsAudioCapture\Intermediate\Build\Win64\UnrealEditor\Inc\WindowsAudioCapture\UHT\WindowsAudioCaptureComponent.gen.cpp:64]
Untitled

I don't really know what I'm doing but my setup looks like this:

@kabassmusic
Copy link

@benjs2000 Set your Tick Interval to 0.02.

This is happening because it's running too frequently on Tick.

@benjs2000
Copy link
Author

@kabassmusic Have tried tick interval 0.02. Set it in the WAC component of the blueprint but same crash occurs. Hmmm.

@kabassmusic
Copy link

kabassmusic commented Dec 20, 2022

@benjs2000

Interesting. Try setting a delay on tick to 1 second.
I witnessed the same crash when I had the interval to 0, but it didn't with 0.02. I wonder if this is based on framerate or hardware performance. Not sure and that's a rough guess.

EDIT: You said you set it in the component, set it in the blueprint instead.

@benjs2000
Copy link
Author

@kabassmusic Thanks for the suggestion - have tried 1 second tick in the blueprint as well but same error unfortunately.
Hardware is 10600k/3080 but not sure if that makes a difference here.
I was thinking it might be something to do with my default output device (ASIO USB Interface), but the demo project runs just fine so really not sure.

@benjs2000
Copy link
Author

benjs2000 commented Dec 21, 2022

@kabassmusic Update: I got it working in 5.1 5.0 with the 4.26 fork by @kabassmusic.
Edit 5.1 not working at time of comment

@chrixbedardcad
Copy link

@benjs2000 Okay. I have tested the 4.26 version with 5.1 and it rebuilt and packaged fine. Try out my fork and let me know.

https://github.com/kabassmusic/WAC-4.26

Did you manage to rebuild it for 4.27.2 by any chance ?

@kabassmusic
Copy link

@chrixbedardcad It should just work. You'll just get a popup every time that says it was made for an older version but it'll still build anyways.

@chrixbedardcad
Copy link

@kabassmusic I try and I get that window message and the project will not open.
2022-12-31_10-43-26

@benjs2000
Copy link
Author

benjs2000 commented Jan 1, 2023

I had the same issue but followed this tutorial: (just build in ide)
https://www.youtube.com/watch?v=1ogc1TdhGvE&t=198s&ab_channel=ValsogardEnterprise

Also, I seem to be having issues in 5.1. Seems to work ok on 5.0 though. @chrixbedardcad

@kabassmusic
Copy link

@benjs2000 I havent actually tested it on 5.1 yet. Is it still crashing?

@Th-Asencio
Copy link

Th-Asencio commented Jan 8, 2023

Hello,

First, thank you so much for sharing your work and supporting evolutions. It got me to finally open UE and make something.

I have just started learning UE, and I tried creating a project with your plugin.
Using UE5.1, I had to install VS as well as .NET SDKs 7, 6, and 4.6.0 specifically for some reason.

I got it working, dabbled a bit with blueprints to make a cube scale up and down with the bass, but whatever I do, UE crashes when the music stops.
I tried messing with the parameters (Offset etc), but whenever the music stops while WAC is being called, UE crashes.

Any insight on whether the problem comes from my usage of the plugin or from the plugin itself?

You will find below a screen of the most basic setup I got to crash, and the associated log when the music stops at 15.20.33:666.

image
`[2023.01.08-15.20.21:472][549]PIE: Server logged in
[2023.01.08-15.20.21:473][549]PIE: Play in editor total start time 0,17 seconds.
[2023.01.08-15.20.21:483][549]LogViewport: Scene viewport resized to 1280x720, mode Windowed.
[2023.01.08-15.20.33:666][448]LogOutputDevice: Warning:

Script Stack (1 frames) :
/Game/StarterContent/Shapes/Actor_Blueprint.Actor_Blueprint_C.ExecuteUbergraph_Actor_Blueprint

[2023.01.08-15.20.33:679][448]LogWindows: Error: appError called: Fatal error: [File:D:\build++UE5\Sync\Engine\Source\Runtime\Core\Private\Containers\Array.cpp] [Line: 8]
Trying to resize TArray to an invalid size of 4294967295

[2023.01.08-15.20.33:679][448]LogWindows: Windows GetLastError: L’opération a réussi. (0)`

@benjs2000
Copy link
Author

@Th-Asencio I was having the exact same issue but hotfixed it with a hacky fix a few days ago. I'll get back to you in the next few hours.

@benjs2000
Copy link
Author

@Th-Asencio @kabassmusic I got things working in 5.1 with this fork.

https://github.com/benjs2000/WAC-4.26

@Th-Asencio
Copy link

Th-Asencio commented Jan 8, 2023

Thank you, I will try it out right now!

Edit: Works fine so far, I will let you know if I face other issues

@kabassmusic
Copy link

kabassmusic commented Jan 8, 2023

@benjs2000 So changing it from float to int32 fixed that bug?
I wonder if updating my fork will let it still work on previous versions too.

@benjs2000
Copy link
Author

benjs2000 commented Jan 8, 2023

@kabassmusic The issue was that if the length of the frequencies (freq.num or smth) was less than 0 then it crashes so the if statement fixes it.

@kabassmusic
Copy link

@benjs2000 Fantastic, I'll update my fork and credit you with changes. Really glad that people have come together to fix this outdated plugin!

@Slipstream269
Copy link

Slipstream269 commented Feb 19, 2024

@benjs2000 Fantastic, I'll update my fork and credit you with changes. Really glad that people have come together to fix this outdated plugin!

@kabassmusic Did you get a chance to incorporate these fixes in your latest build as i'm experiencing the same crashes when no sounds are playing. Thanks!

@bytenugget
Copy link

I managed to bypass the crash, as others mentioned above. But now, after a short while, it just stops giving any output. Bypassing the invalid size crash, does not seem to be a solution.

@Slipstream269
Copy link

I managed to bypass the crash, as others mentioned above. But now, after a short while, it just stops giving any output. Bypassing the invalid size crash, does not seem to be a solution.

found an update to this one mate, works in 5.1 and the latest preview 5.4 (I assume all the versions in between too)

https://github.com/h616311501/WAC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants
@kabassmusic @Th-Asencio @benjs2000 @chrixbedardcad @Slipstream269 @bytenugget and others