Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect code reference for compression/uncompression #30

Closed
sshanks-kx opened this issue Sep 10, 2020 · 2 comments
Closed

Incorrect code reference for compression/uncompression #30

sshanks-kx opened this issue Sep 10, 2020 · 2 comments

Comments

@sshanks-kx
Copy link
Contributor

https://code.kx.com/q/basics/ipc/#compression
"The compression/decompression algorithms are proprietary and implemented as the z and u methods in c.java"

Should prob be
"The compression/decompression algorithms are proprietary and implemented as the compress and uncompress methods in c.java"

Background:
https://github.com/KxSystems/javakdb/blob/c9afe6fa32d7d3e3cddabdc9bd43f0155a5d2a1b/src/kx/c.java
Original has z/u methods

changed as part of 'reformatted, documented and provided simple examples' Jun 16 2017
KxSystems/javakdb@5e1ee8f#diff-6ad7d9db62e45794ad1ae4af83abecdd

Now uses 'compress' and 'uncompress' methods
https://github.com/KxSystems/javakdb/blob/master/src/kx/c.java

@ghost
Copy link

ghost commented Sep 17, 2020

Thanks for spotting this.

@ghost ghost closed this as completed Sep 17, 2020
@sshanks-kx
Copy link
Contributor Author

Fix on #31 (github should have auto added a link but doesnt appear to have happened)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant