Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken memoryview format #62

Closed
kyamagu opened this issue Jun 10, 2020 · 1 comment
Closed

Broken memoryview format #62

kyamagu opened this issue Jun 10, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@kyamagu
Copy link
Owner

kyamagu commented Jun 10, 2020

Describe the bug
APIs that return memoryview does not have valid format, forcing the user to call cast('B') before using any memory manipulation.

To Reproduce

view = pixmap.addr8()
view[0]  # This crash
view.cast('B')[0]

Expected behavior
Should not require cast

Desktop (please complete the following information):

  • OS: macOS 10.15.5
  • Architecture x86_64
  • Python 3.7
  • skia-python version v0.0.4

Additional context
See pybind/pybind11#2223
@kyamagu kyamagu added the bug Something isn't working label Jun 10, 2020
@kyamagu kyamagu mentioned this issue Oct 21, 2020
Closed
@kyamagu
Copy link
Owner Author

kyamagu commented Nov 17, 2020

Likely fixed in #123

@kyamagu kyamagu closed this as completed Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kyamagu