Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully support ISO 639-1 #2

Closed
shiftpsh opened this issue Sep 30, 2020 · 2 comments
Closed

Fully support ISO 639-1 #2

shiftpsh opened this issue Sep 30, 2020 · 2 comments
Assignees
@kyaryunha
Labels
good first issue Good for newcomers TODO

Comments

@shiftpsh
Copy link

If no language was set by user, this library defaults to system language truncated to 2 characters, resulting 'en-US' and 'en-GB' to be both just 'en', or 'zh-CN' and 'zh-TW' to be both just 'zh'.
@kyaryunha
Copy link
Owner

Thank you for the issue.
I will try to add that feature in October.

It will be updated as follows:
In the case of "en-US" and "en-GB", try to match "en-us" and "en-gb", and in the case of failure, try to match "en".

@kyaryunha kyaryunha self-assigned this Oct 2, 2020
@kyaryunha kyaryunha added good first issue Good for newcomers help wanted Extra attention is needed TODO and removed help wanted Extra attention is needed labels Oct 2, 2020
@kyaryunha
Copy link
Owner

Hello. Thanks for the good suggestion.
The function has been updated and is supported from version 1.0.7 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyaryunha kyaryunha

Labels
good first issue Good for newcomers TODO
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shiftpsh @kyaryunha