Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NvimTreeImageFile highlight not working for webp and jxl files #2450

Closed
zootedb0t opened this issue Oct 7, 2023 · 3 comments · Fixed by #2451
Closed

NvimTreeImageFile highlight not working for webp and jxl files #2450

zootedb0t opened this issue Oct 7, 2023 · 3 comments · Fixed by #2451
Labels
bug Something isn't working

Comments

@zootedb0t
Copy link
Contributor

Description

Image files such as png,jpg are highlighted with NvimTreeImageFile highlight group, but this highlight group doesn't apply for webp,jxl image files.

Screenshot_2023-10-07-06-51-26_1920x1080

Neovim version

NVIM v0.10.0-dev-1278+g1e7e9ee91
Build type: RelWithDebInfo
LuaJIT 2.1.1695653777

Operating system and version

Linux archBTW 6.5.5-arch1-1 #1 SMP PREEMPT_DYNAMIC Sat, 23 Sep 2023 22:55:13 +0000 x86_64 GNU/Linux

nvim-tree version

master, 85abe29

Clean room replication

vim.g.loaded_netrw = 1
vim.g.loaded_netrwPlugin = 1

vim.cmd [[set runtimepath=$VIMRUNTIME]]
vim.cmd [[set packpath=/tmp/nvt-min/site]]
local package_root = "/tmp/nvt-min/site/pack"
local install_path = package_root .. "/packer/start/packer.nvim"
local function load_plugins()
  require("packer").startup {
    {
      "wbthomason/packer.nvim",
      "nvim-tree/nvim-tree.lua",
      "nvim-tree/nvim-web-devicons",
      -- ADD PLUGINS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. "/plugin/packer_compiled.lua",
      display = { non_interactive = true },
    },
  }
end
if vim.fn.isdirectory(install_path) == 0 then
  print "Installing nvim-tree and dependencies."
  vim.fn.system { "git", "clone", "--depth=1", "https://github.com/wbthomason/packer.nvim", install_path }
end
load_plugins()
require("packer").sync()
vim.cmd [[autocmd User PackerComplete ++once echo "Ready!" | lua setup()]]
vim.opt.termguicolors = true
vim.opt.cursorline = true

-- MODIFY NVIM-TREE SETTINGS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
_G.setup = function()
  require("nvim-tree").setup {}
end

Steps to reproduce

  1. nvim -nu /tmp/nvt-min.lua
  2. Open NvimTree inside any project that has webp files.

Expected behavior

webp files should have same highlight as png file.

Actual behavior

webp file has different highlight than png,jpg files.

@zootedb0t zootedb0t added the bug Something isn't working label Oct 7, 2023
@Akmadan23
Copy link
Collaborator

You're right, as of now the only image extensions highlighted as NvimTreeImageFile are jpg, jpeg, png and gif. This can be easily fixed, I'll take care of it right away.

@Akmadan23
Copy link
Collaborator

Sorry I completely missed your PR... 😅

@alex-courtis
Copy link
Member

alex-courtis commented Oct 8, 2023

nvim-tree/nvim-web-devicons#318 should be sufficient.

Edit: it is not. This change was necessary to apply NvimTreeImageFile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants