Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: update_perms broken #2892

Closed
zoemartin01 opened this issue Nov 19, 2020 · 0 comments
Closed

BUG: update_perms broken #2892

zoemartin01 opened this issue Nov 19, 2020 · 0 comments

Comments

@zoemartin01
Copy link
Contributor

bot.py#update_perms is currently broken and only inserts into command_permissions even when it should write into level_permissions causing all existing command_permissions overrides in the database being completely overwritten every time you add or remove a new level permission.

Cause:
https://github.com/kyb3r/modmail/blob/802e74040797c9c64b285d50c4267625b4a5b82e/bot.py#L992

due to this the below following
https://github.com/kyb3r/modmail/blob/802e74040797c9c64b285d50c4267625b4a5b82e/bot.py#L1006
is always false.

@fourjr fourjr closed this as completed in 03899d2 Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant