Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check whether component is not destroyed inside next #29

Merged
merged 1 commit into from Aug 21, 2017
Merged

Check whether component is not destroyed inside next #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions addon/components/ember-attacher-inner.js
View file
Open in desktop
Expand Up @@ -240,6 +240,10 @@ export default Component.extend({
// turn on the same time as our show animation, and `display: none` => `display: anythingElse`
// is not transition-able
next(this, () => {
if (this.isDestroyed || this.isDestroying) {
return;
}

const showDuration = parseInt(this.get('showDuration'));

this.element.style.transitionDuration = `${showDuration}ms`;
Expand Down