Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0 Roadmap #34

Open
kybishop opened this issue Aug 28, 2017 · 7 comments
Open

v1.0.0 Roadmap #34

kybishop opened this issue Aug 28, 2017 · 7 comments

Comments

@kybishop
Copy link
Owner

kybishop commented Aug 28, 2017

Wanted to start a discussion on 1.0. There is no rush on this, but it seems like we have a pretty solid API and, as a result, 1.0 shouldn't be far off.

Things I see as blockers:
1. Discuss and come to a final decision on closure actions vs sendAction approach for onFoundTarget.
2. A barebones github.io dummy app (maybe steal something similar to kybishop/ember-attacher?)
3. Update the README.md

EDIT: We will go to v1.0.0 once we go 2 months without a breaking change or major concern. From there we will follow strict semver.

@srvance
Copy link

srvance commented Aug 28, 2017

Hi, @kybishop. With Bootstrap 4 now adopting popper.js for positioning as of the beta release, we're looking into using ember-popper to handle equivalent positioning in ember-bootstrap, possibly for Bootstrap 3 and 4. The time I spent on it this weekend wasn't very successful, but I think we'll have more feedback as the work progresses.

@pzuraq
Copy link
Collaborator

pzuraq commented Sep 18, 2017

@srvance what issues did you have in particular? Definitely interested in getting feedback on the API now, before v1. Glad to help, and feel free to ping us on Slack in #dev-html-next too

Re: sendAction vs closure actions, I think we should stick to closure actions. That particular event should almost definitely be synchronous, so I don't think the runloop scheduling behavior will be good. For backwards compat 1.11 users can just define a function on the parent object and pass it in I believe.

@srvance
Copy link

srvance commented Sep 19, 2017

@simonihmig has taken over the efforts on this and gotten much, much farther than I was able.

@kybishop
Copy link
Owner Author

kybishop commented Dec 2, 2017

My general thoughts on this are that we should wait on 1.0 until we have at least 2 straight months without the need for a breaking change. The recent necessary change to switch the target arg to popperTarget (#62) resets that clock today. If we hit the end of January without breaking changes or major concerns, I think we can safely publish 1.0.0

@sir-dunxalot I know you recently attempted to use ember-popper in a refactor of ember-tooltips but ran into a roadblock of some kind. I'd love hear your thoughts to see if we can accommodate any/all users.

In the same vain, I'd love to hear about any major concerns from any/all users (@simonihmig, etc.).

@simonihmig
Copy link
Collaborator

Sounds good. Will try to update for the latest changes over the weekend.

@simonihmig
Copy link
Collaborator

Just updated ember-bootstrap for the target change, was pretty easy, and all tests still passing. So no concerns so far from my side, looking forward for a stable release!

@kybishop kybishop changed the title 1.0 Roadmap v1.0.0 Roadmap Dec 3, 2017
@acorncom
Copy link

acorncom commented Dec 6, 2019

@simonihmig think a stable release should be cut? Looks like 2 months have gone by without a breaking change ... 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants