Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'-start' & '-end' shift ? #74

Closed
ctjhoa opened this issue Jan 19, 2018 · 3 comments
Closed

'-start' & '-end' shift ? #74

ctjhoa opened this issue Jan 19, 2018 · 3 comments

Comments

@ctjhoa
Copy link
Contributor

ctjhoa commented Jan 19, 2018

Hi,

According to the Popper.js doc and some tests, popper.js handle some placement like bottom-start.

https://codepen.io/anon/pen/Ozrrmr

In your source you limit the placement to the main value

Placement of the popper. One of ['top', 'right', 'bottom', 'left'].

Is there a reason? Are these placement values should work even if it's undocumented?

Thanks

@pzuraq
Copy link
Collaborator

pzuraq commented Jan 19, 2018

I believe the other values can be used and we should probably update the docs to reflect that

@simonihmig
Copy link
Collaborator

@ctjhoa
Copy link
Contributor Author

ctjhoa commented Jan 22, 2018

Nice thanks!

@ctjhoa ctjhoa closed this as completed Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants