Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tot_dfs() got an unexpected keyword argument 'confidence_threshold' #52

Closed
claudiobottari opened this issue May 30, 2023 · 2 comments
Closed

Comments

@claudiobottari
Copy link

Getting few errors likes this, should I fix it?

tree-of-thoughts\tree_of_thoughts\treeofthoughts.py", line 45, in solve
result = self.tot_dfs(initial_prompt, num_thoughts, max_steps, value_threshold,
TypeError: tot_dfs() got an unexpected keyword argument 'confidence_threshold'

@ivanzhovannik
Copy link

ivanzhovannik commented May 30, 2023

@claudiobottari I have got bunch of those, too :( Basically self.tot_dfs and self.tot_bfs have a set of different arguments and no unified wrapper around them, so I edited the TreeofThoughts class source file in my conda environment

@kyegomez some points:

  • there are some misspellings here - "inital -> initial"
  • what do you think about wring one traversal method, which will incapsulate the run of either DFS or BFS under the hood, so that the issue of different args is solved?

@kyegomez
Copy link
Owner

kyegomez commented May 30, 2023

Yeah changed 1, can you go deeper on number 2? @ivanzhovannik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants