Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine/postgres: Upgrade to pg_query_go/v4 #2114

Merged
merged 8 commits into from
Feb 27, 2023
Merged

Conversation

kyleconroy
Copy link
Collaborator

@kyleconroy kyleconroy commented Feb 24, 2023

It appears the v4 does not support ? placeholders anymore. The following query fails with a parse error:

SELECT * FROM users WHERE id = ?;

Update: These queries would never have worked in the first place, as the PostgreSQL server does not support the ? syntax. Going to go ahead and merge this :)

@kyleconroy kyleconroy changed the title Upgrade package, many build errors engine/postgres: Upgrade to pg_query_go/v4 Feb 24, 2023
@kyleconroy kyleconroy marked this pull request as ready for review February 25, 2023 00:03
@kyleconroy kyleconroy merged commit a71c584 into main Feb 27, 2023
@kyleconroy kyleconroy deleted the kyle/upgrade-pg-query-go branch February 27, 2023 18:36
@oliverpool
Copy link
Contributor

I have been using the postgres engine and then running my code on sqlite (since the sqlite engine is missing a few features).
So I just got bitten by this change (but since my workflow is hacky, this is not a real surprise).

Replacing all ? is not so tedious and thanks to compile time type checking, I am pretty confident of update 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants