Allow sql_package: "go-sql-driver/mysql" #2219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran a basic test locally, but real tests will come with the next PRs for that issue. |
kyleconroy
requested changes
Apr 20, 2023
There was a problem hiding this comment.
I think we want to add a new configuration option for this instead of re-using sql_package. The current value changes the package to use, either database/sql or pgx/v4 or pgxv5. In this case we're still using database/sql as a base, but using the mysql driver to do some additional work.
I think adding a new sql_driver override is the way to go and require it to be set to the full import path of github.com/go-sql-driver/mysql.
Jille
force-pushed
the
loaddata1
branch
4 times, most recently
from
378ecab
to
d6560ce
Compare
In preparation of sqlc-dev#2179 for LOAD DATA LOCAL INFILE
|
Done |
kyleconroy
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of #2179 for LOAD DATA LOCAL INFILE