Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pointers overrides skip imports in generated query files #2240

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

ludusrusso
Copy link
Contributor

@ludusrusso ludusrusso commented Apr 28, 2023

fixes #2239

@kyleconroy sorry but it seems that my previous PR was not complete.

@kyleconroy kyleconroy merged commit d8f1f73 into sqlc-dev:main Apr 28, 2023
6 checks passed
@tschaub
Copy link

tschaub commented Jun 7, 2023

I think I'm running into the same issue that this fix addresses (see #2304).

@ludusrusso - do you know of the most recent release where imports are included in the generated files (I know things worked at 1.12.0)?

@ludusrusso
Copy link
Contributor Author

I think I'm running into the same issue that this fix addresses (see #2304).

@ludusrusso - do you know of the most recent release where imports are included in the generated files (I know things worked at 1.12.0)?

1.16 should work!

@tschaub
Copy link

tschaub commented Jun 7, 2023

1.16 should work!

Thanks.

I was hoping to also find a solution to #1956 (which is present in 1.16). Hoping for a patch release that includes your fix at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pointers overrides arguments still not imported properly in codegen in v1.18
3 participants