fix: fix toSnakeCase to handle input in camel case format #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orisano
force-pushed
the
fix-improve-snake
branch
from
ee030b7
to
2d136f1
Compare
orisano
changed the title
kyleconroy
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2243
Previously, SetCaseStyle was used only for column names (snake case), so the
toSnakeCasefunction worked correctly with strings.ToLower only.Convert the model name (camel case) to snake case to get the tag name used in
sqlc.embed.This breaks the precondition of the
toSnakeCasefunction and it no longer works correctly.So we fixed the
toSnakeCasefunction to work correctly even if the input is camel case.If the proposed fix approach is incorrect, please let me know and feel free to close this PR