internal/config: support golang overrides for slices #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the "go_type" override property, and update docs
kyleconroy
reviewed
Jun 19, 2023
andrewmbenton
force-pushed
the
allow-golang-slice-overrides
branch
from
1aa6d83
to
2647552
Compare
kyleconroy
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating a fix for #2316 I discovered some generally unexpected behavior when attempting to get sqlc to generate slices of types in overrides for Go code gen. So I added a boolean
"slice"property to the"go_type"property of the overrides object array, which behaves similarly to the"pointer"property.This doesn't "fix" the above-referenced issue per se, but it does provide a more explicit way to tell sqlc how to achieve the desired result.
The docs I wrote may be wrong, so feel free to advise on any changes and I'll incorporate them.