Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't defer rows.Close() if pgx.BatchResults.Query() failed #2362

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Don't defer rows.Close() if pgx.BatchResults.Query() failed #2362

merged 2 commits into from
Jun 27, 2023

Conversation

Jille
Copy link
Contributor

@Jille Jille commented Jun 22, 2023

To appease staticcheck

@Jille
Copy link
Contributor Author

Jille commented Jun 22, 2023

cc @chrisyxlee I think you introduced this in 0ebe855

@chrisyxlee
Copy link
Contributor

thanks for catching!

@kyleconroy kyleconroy merged commit 6431b06 into sqlc-dev:main Jun 27, 2023
7 checks passed
andrewmbenton pushed a commit that referenced this pull request Jun 27, 2023
@Jille @andrewmbenton
fix: Don't defer rows.Close() if pgx.BatchResults.Query() failed (#2362)
8d616db 
* Small whitespace change in golang codegen template

* Don't defer rows.Close() if pgx.BatchResults.Query() failed

To appease staticcheck
@Jille Jille deleted the batchresults-close branch June 28, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jille @chrisyxlee @kyleconroy