New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix rewrite to traverse Sel in ast.In #2414

Merged

andrewmbenton merged 1 commit into sqlc-dev:main from orisano:fix/#2403

Jul 12, 2023

Contributor

orisano commented Jul 7, 2023


          fix: fix to traverse Sel in ast.In

7a60641

fix sqlc-dev#2403

orisano changed the title ~~fix: fix to traverse Sel in ast.In~~ fix: fix rewrite to traverse Sel in ast.In

orisano changed the title ~~fix: fix rewrite to traverse Sel in ast.In~~ fix(engine/sqlite): fix rewrite to traverse Sel in ast.In

orisano changed the title ~~fix(engine/sqlite): fix rewrite to traverse Sel in ast.In~~ fix: fix rewrite to traverse Sel in ast.In

Collaborator

andrewmbenton commented Jul 12, 2023

Thanks! I am going to merge this and then create an endtoend test using the input from the playground link provided in #2403: https://play.sqlc.dev/p/4db6630bb57b14ff1913c150a2c0140e9eb4e587f54e93586f430e99681ae83b

andrewmbenton merged commit 156bd6d into sqlc-dev:main

8 checks passed

andrewmbenton mentioned this pull request

Add an endtoend test that covers the case referenced in #2403 #2442

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment