Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation documentation for module underscore #2

Closed
baaskoen opened this issue Jun 16, 2016 · 2 comments
Closed

Add installation documentation for module underscore #2

baaskoen opened this issue Jun 16, 2016 · 2 comments

Comments

@baaskoen
Copy link

If I'm following the installation documentation and try to configure Node Query Builder, I'm getting the following error:

Error: Couldn't load the Connection library for mysql({"user":"root","host":"localhost","database":"myDatabase","password":"myPassword","pool_size":50}): Error: Cannot find module 'underscore'

Perhaps it is a good idea to add npm install underscore to the documentation?

Great work though 👍

@malles
Copy link

malles commented Sep 5, 2016

IT should be added to the dependancies.
The tests on travis also fail because of missing underscore

@kylefarris
Copy link
Owner

I was only using underscore for its extend method. Node has had the native es2015 Object.assign method for some time now so I've removed the underscore dependency and changed all instances of _.extend to Object.assign. That does mean, however, that Node version >= 4.0 is now required (was 0.10). I don't think this is too much of a stretch, though, seeing as version 7+ is out now.

Travis builds are now passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants