Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #205

Closed
wants to merge 1 commit into from
Closed

Update README.md #205

wants to merge 1 commit into from

Conversation

userlond
Copy link

I use jquery.modal version 0.8.0.
Why I've made changes in readme is in the code section below.

$('#container').on($.modal.BEFORE_OPEN, function(event, modal) {
    // prints undefined
    console.log(modal.$elm);    
    // without dollar sign it works
    console.log(modal.elm);
    // blocker works with dollar sign 
    console.log(modal.$blocker);
});

Maybe it will be ok to skip this request prior to some twiks in code to unify properties name (i.e. make working modal.$elm and modal.$blocker (or modal.elm and modal.blocker)).

I use jquery.modal version 0.8.0.
Why I've made changes in readme is in the code section below.

$('#container').on($.modal.BEFORE_OPEN, function(event, modal) {
    // prints undefined
    console.log(modal.$elm);    
    // without dollar sign it works
    console.log(modal.elm);
    // blocker works with dollar sign 
    console.log(modal.$blocker);
});

Maybe it will be ok to skip this request prior to some twiks in code to unify properties name (i.e. make working modal.$elm and modal.$blocker (or modal.elm and modal.blocker)).
@kylefox kylefox closed this in c074130 Jul 3, 2017
@kylefox
Copy link
Owner

kylefox commented Jul 3, 2017

Thanks for pointing this out — I actually stumbled across this exact issue myself today!

To fix without breaking backwards compatibility, I simply aliased modal.$elm and modal.elm — they will both work as of version 0.8.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants