Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close button text is visible with 'direction: rtl' #232

Closed
jlherren opened this issue Sep 17, 2018 · 2 comments
Closed

Close button text is visible with 'direction: rtl' #232

jlherren opened this issue Sep 17, 2018 · 2 comments

Comments

@jlherren
Copy link

The modal's close button uses text-indent: -9999px to hide the "Close" text while keeping the background image attached to the link. This is usually considered bad practice and does not work with direction: rtl, resulting in the text being visible anyway.

An alternate solution is for example proposed here: Stop using negative left or text indents for css hiding

@kylefox
Copy link
Owner

kylefox commented Sep 17, 2018

This project is in maintenance mode — please submit a pull request if you'd like to see this (or any other) new functionality. Thanks.

@kylefox kylefox closed this as completed Sep 17, 2018
@ohmydevops
Copy link

@jlherren add style="text-align: right;" to the modal div to display it correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants