-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container builds need work ... #24
Comments
Thanks for the feedback. Any insight on what the errors were? By the way, the repo you linked to do anything to encrypt the transport https://github.com/akanto/dockvpn/commit/7977c70a827aed6c3e28ebf451493b27415c3717 Thought that was an interesting way to run a VPN. On Tue, Jan 06, 2015 at 05:23:35PM -0800, Jason Gegere wrote:
|
The errors had todo with the TLS certificate not being read by Tunnelblick, I actually sent you a email directly. I would be happy to share more. I am updating the readme of another repo testing and will commit soon, after my tests. The link you provided was my fault, I linked correctly. Yeah disabling encryption is bad! |
phew... hours later! I have create an updated repo using your data container idea with the corrections from rsc-1/dispos-a-vpn Maybe we could combine forces. I noticed many bad practices with people branching off the initial build. |
Glad to hear you got it working!
The initial build was a bad idea for production systems and appears to be meant as a blog post and proof of concept. Static shared keys? Key distribution via unauthenticated https? I need not say more as these have been resolved in my image for a long time.
As for combining, I accept pull requests that fix documentation issues or bugs! Feel free to send them this way. I'm closing this issue because there is nothing actionable here. |
I agree. The initial was a simple start. I will issue a pull request to you but it is messy with commits. |
Sounds good. Please squash your commits so they are coherent and |
I spent most of the day working at this and following your instructions. I think you did a great job but there are a few issue and I ended up using the build from rsc-1/dispos-a-vpn
I appreciate the time and effort you put into your build, cheers!
The text was updated successfully, but these errors were encountered: