Section custom spacing #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleve
reviewed
Jun 10, 2020
Listable/Sources/Section.swift
Outdated
| @@ -152,10 +152,13 @@ public extension Section | |||
| struct Layout : Equatable | |||
| { | |||
| public var width : CustomWidth | |||
|
|
|||
| public var customSpacing : CGFloat? | |||
There was a problem hiding this comment.
Maybe customInterSectionSpacing?
|
For testing, I have a temp test kicking around here: https://github.com/kyleve/Listable/blob/main/Listable/Tests/Layout/List/DefaultListLayoutTests.swift#L71 which I'm using to allow for refactoring of the layout system without breaking things (after which will backfill more tests). Could update that with this property to test it does what's expected |
|
@kyleve I addressed your comments, ptal |
|
Looks good, thanks! I forgot to mention this earlier, but could you drop an item in the |
kyleve
approved these changes
Jun 10, 2020
- Add `customInterSectionSpacing` property to `Section.Layout` which allows the user to specify custom spacing after a section, overriding the calculated spacing.
gilbox
force-pushed
the
gil/section-customSpacing
branch
from
88c9d8b
to
44b72ff
Compare
|
@kyleve I updated the changelog and squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could use some advice for adding a test...
