Content Updated Changes #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleve
commented
Aug 19, 2020
| self.coordination.coordinator.wasCreated() | ||
| /// Now that we are set up, notify callbacks. | ||
|
|
||
| self.model.onInsert?(.init(item: self.model)) |
There was a problem hiding this comment.
Needs to be in the update callback
kyleve
commented
Aug 19, 2020
| @@ -281,7 +301,8 @@ extension PresentationState | |||
|
|
|||
| func wasRemoved() | |||
| { | |||
| self.coordination.coordinator.wasRemoved() | |||
| self.model.onRemove?(.init(item: self.model)) | |||
There was a problem hiding this comment.
Needs updateCallbacks
kyleve
commented
Aug 19, 2020
| moved: { old, new, changes, section in section.update(with: old, new: new, changes: changes, dependencies: dependencies) }, | ||
| noChange: { old, new, changes, section in section.update(with: old, new: new, changes: changes, dependencies: dependencies) } | ||
| removed: { _, section in | ||
| updateCallbacks.add { |
kyleve
commented
Aug 19, 2020
| @@ -853,6 +865,38 @@ public final class ListView : UIView | |||
| } | |||
|
|
|||
|
|
|||
| public final class UpdateCallbacks { | |||
kyleve
force-pushed
the
kve/change-to-content-updated
branch
from
b304a17
to
a59f3ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.