Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix autolayout sizing for items and headers/footers #228

Merged
merged 5 commits into from Dec 11, 2020
Merged

Fix autolayout sizing for items and headers/footers #228

merged 5 commits into from Dec 11, 2020

Conversation

kyleve
Copy link
Collaborator

@kyleve kyleve commented Oct 28, 2020 •
edited

No description provided.

@kyleve kyleve requested a review from kylebshr October 28, 2020 23:29
kyleve
kyleve commented Oct 29, 2020
View reviewed changes
ListableUI/Sources/Sizing.swift

let size : CGSize = {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If UIView.noIntrinsicSize gets passed instead of zero, does the same thing happen? Nicer for contextual understanding

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UIView.layoutFittingCompressedSize has a size of zero, so could use the width/height of it for context. UIView.noIntrinsicSize is -1... might do the same thing but not sure

@kyleve
Move from notification center to a cell tracker for swipe actions.
1f29bc4
@kyleve
Merge remote-tracking branch 'origin/main' into kve/fix-autolayout-si…
60fd845 
…zing

* origin/main:
  Move CI to GitHub Actions
  Add circle CI config
  Xcode 11 build fixes
  Fix handling of the frame changing properly
  Update docs
  Prepare to release 0.12.0
@kyleve kyleve merged commit 72b5318 into main Dec 11, 2020
@kyleve kyleve deleted the kve/fix-autolayout-sizing branch December 11, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsillik nsillik nsillik left review comments

@kylebshr kylebshr kylebshr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kyleve @nsillik @kylebshr