Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a didPerform callback for AutoScrollAction. #229

Merged
merged 2 commits into from Nov 28, 2020
Merged

Add a didPerform callback for AutoScrollAction. #229

merged 2 commits into from Nov 28, 2020

Conversation

kyleve
Copy link
Collaborator

@kyleve kyleve commented Oct 29, 2020

This way actions don't occur in the shouldPerform method, which should be idempotent.

@kyleve kyleve requested a review from kylebshr October 29, 2020 20:52
kylebshr
kylebshr approved these changes Oct 29, 2020
View reviewed changes
ListableUI/Sources/ListView/ListView.swift Outdated Show resolved Hide resolved
kylebshr
kylebshr approved these changes Oct 30, 2020
View reviewed changes
ListableUI/Sources/AutoScrollAction.swift Outdated Show resolved Hide resolved
ListableUI/Sources/ScrollAnimation.swift Show resolved Hide resolved
ListableUI/Sources/ScrollAnimation.swift Show resolved Hide resolved
@kyleve kyleve merged commit 6e871ac into main Nov 28, 2020
@kyleve kyleve deleted the kve/autoscroll-did-perform branch November 28, 2020 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylebshr kylebshr kylebshr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kyleve @kylebshr