Fix crash that occurs when transitioning to a zero size view #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebshr
approved these changes
Mar 1, 2021
|
Took a better shot at this here: #273 |
|
Thank you for the quick fix! |
Fix crash that occurs when transitioning to a zero size view, but better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that occurs when list view transitions from a sized view, to one with zero area. This happens because when the size transitions to a zero area view, we remove all content – it doesnt mean anything to lay out content that has no possible size. Unfortunately, when updating the visible content, we depend on the collection view's layout, which has not yet updated, and causes a crash due to returning content that no longer exists. The fix here is to return early in this case.
I think there might be a more holistic way to fix this by updating the visible content at a slightly different time, but this does the trick for now. I'll keep playing with it.